Route a method whose name is a reserved word. #11890
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Helpful things
Fixes
Fixes #11439
Purpose
What does this PR do?
Background Context
Why did you take this approach?
@mkurz commented #11439 (comment) that we might be able to escape all the method we generate with backticks. While I was working on the issue I discovered there already is a
safeKeyword
method. I added asafeMethod
method that is almost identical in functionality.@proudust created a project that reproduces the issue. A couple of routes in the project have backticks around the method name. That's why I added functionality to the
RoutesFileParser
to parse routes with backticks around the method name.I don't know if this is desirable. By allowing backticks around the method name a route like
GET /space controllers.FooController.` `()
should also be valid. @mkurz What do you think?References
Are there any relevant issues / PRs / mailing lists discussions?